[libavg-devel] Div Node Rotations Patch

[Ulrich von Zadow]

Ulrich von Zadow schrieb:
> Nick Hebner schrieb:
> 
>>     Right, duplicated code is not ok - all of the angle stuff should 
>> move to
>>     node. There are two node types for which this is an issue, though: 
>> <avg>
>>     and <panoimage>. For <avg>, we need to prevent angle and pivot from
>>     being set by overriding the appropriate functions etc., and
>>     <panoimage>... well actually, we should be able to make angle work 
>> for
>>     <panoimage> easily, right?
>>
>>     (Not that this is perfect design, but it's good enough and I really
>>     don't have a better practical idea right now.)
>>
>> Ok, I will move that stuff to Node. I was also wondering what 
>> PanoImage is all about. What is the difference between it and Image?
> 
> PanoImage is a panorama image. It applies a cylindrical projection to 
> the image, similar to what quicktime vr does. You can change which part 
> of the image is displayed by changing the rotation attribute. We needed 
> PanoImage for this device: http://www.timescope.de/default.asp?lang=en :-).
> 
>>     What we need before I check this in (other than fixes for the two
>>     issues
>>     you've already mentioned), is an automatic test so this doesn't break
>>     without us knowing. Attached is a patch for src/test that adds a test
>>     for correct image & mouse event handling, and an appropriate image
>>     to be
>>     placed in src/test/baseline.
>>
>>
>> Is the attached test enough or should I expand it?
> 
> The test I wrote just checks <div>. Once <panoimage> support is there, 
> we'll need a test for that too. Other than that... of course, if you 
> discover something that's not covered by the test, feel free to add that 
> too, but this test checks for correct angle setting for simple and 
> nested divs and also tests if the angle is applied to mouse event 
> handling. Is there anything I'm forgetting?

Um yeah, there is. To run the test, you need the attached avg file.

--

Ulrich von Zadow | +49-172-7872715 | cocacoder at jabber.berlin.ccc.de

-------------- next part --------------
A non-text attachment was scrubbed...
Name: rotate.avg
Type: text/xml
Size: 564 bytes
Desc: not available
Url : http://mail.datenhain.de/pipermail/libavg-devel/attachments/20070818/9498533f/rotate.bin