[libavg-devel] v4l branch code review

[Ulrich von Zadow]

Hi,

I finally found the time to look through the code in the v4l branch and
updated it to newest trunk. Overall, everything looks very good and I
think it's ok to merge to trunk whenever you think everything is ok.
I'll probably clean up the firewire modesetting stuff so everything is
consistent once you've done the merge.

Still, some minor points:

- Some of the indentation is still broken.

- There are some (actually, many) coding convention violations. I think
I forgot to tell you about the coding conventions, so we can leave
current code like it is (or maybe I'll fix it). Still, please read
https://www.libavg.de/wiki/index.php/Coding_Conventions if you haven't
already and stick to them for any new code.

- Bitmap.cpp, 832ff: Have you benchmarked this code to make sure it
isn't eating up too much cpu time? It looks slow.

- V4LCamera.cpp

206ff: Is anything other than IO_METHOD_MMAP still used? If not, the
code here will never be tested anymore and will become buggy. Also, less
code is always good, so it should probably be removed. If you've got a
good reason for keeping it there, add an appropriate comment.


I'll probably buy a cheap USB camera myself just to see your stuff in
action :-).

Cheers,

  Uli