[libavg-devel] CMU 1394 Digital Camera Support

[Nick Hebner]

On Sun, Nov 16, 2008 at 4:47 AM, Ulrich von Zadow <uzadow at libavg.de> wrote:

> Hi Nick,
>
> cool. I just tried it and after a few VS 2005-related fixes, it showed nice
> pictures taken by my Fire-i.


Cool, glad you got it working! I am using a Fire-i as well.


> Nothing but a few coding convention violations are holding back the commit:
>
> - Always use {} to start a new block in an if.


Added to patch.

>
> - Use type prefixes before variables where appropriate (p before pointers
> etc).


The only instance of this I could find was the control variable in
CMUCamera::setFeature(). Were there others?

>
> - Use an 8-space indent for statement continuations.
>

Added to patch.

>
> Other than that... I like the distinction between m_FramePixelFormat and
> m_OutputPixelFormat. Should have thought of that long ago. We might want to
> move the pixel format conversion to a base class - would save a lot of
> duplicated code.
>

Yeah I think that would be a good idea. I initially copied the FWCamera
implementation, but it seemed to be doing too much work, so I rolled my own.
This code should be identical for all cameras, however.

>
> I'm attaching a changed version of the patch that includes the fixes needed
> for VS 2005.
>

I'm attaching a changed version of the patch that includes the coding
convention fixes. :) I think that I addressed all the issues mentioned.
Please let me know if I missed something.

Thanks,

Nick


>
> Cheers,
>
> Uli
>
>
>
>
>
> On Nov 14, 2008, at 8:48 AM, Nick Hebner wrote:
>
>  Hey All,
>>
>> I finished my first pass at implementing a camera capture subsystem based
>> on the CMU 1394 camera driver. At this point, I believe that it should be as
>> functional as the libdc1394 camera for linux, but if anyone else would like
>> to kick the tires, that would certainly help. I have added instructions for
>> setting up the CMU 1394 development files to the wiki.
>>
>> Thanks,
>>
>> Nick
>>
>> <cmucam.patch>_______________________________________________
>> libavg-devel mailing list
>> libavg-devel at datenhain.de
>> https://mail.datenhain.de/mailman/listinfo/libavg-devel
>>
>
> --
> Any technology distinguishable from magic is insufficiently advanced.
>
> Ulrich von Zadow | +49-172-7872715
> Jabber: coder at c-base.org
> Skype: uzadow
>
>
>
>
> _______________________________________________
> libavg-devel mailing list
> libavg-devel at datenhain.de
> https://mail.datenhain.de/mailman/listinfo/libavg-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.datenhain.de/pipermail/libavg-devel/attachments/20081116/0a14784f/attachment-0001.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmucam.patch
Type: application/octet-stream
Size: 20942 bytes
Desc: not available
Url : http://mail.datenhain.de/pipermail/libavg-devel/attachments/20081116/0a14784f/attachment-0001.obj